Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent regressions with requiring sprockets/railtie #527

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Prevent regressions with requiring sprockets/railtie #527

merged 1 commit into from
Jul 31, 2024

Conversation

etiennebarrie
Copy link
Contributor

Some applications or gems don't require sprockets/rails, instead they load sprockets/railtie.

This change catches this issue when running tests.

$ git checkout v3.5.0
HEAD is now at 5f6d88d Release 3.5.0
$ git cherry-pick --no-commit prevent-regression-for-sprockets-railtie 
$ bundle exec rake >/dev/null 2>&1 || echo failed
failed

@etiennebarrie
Prevent regressions with requiring sprockets/railtie
1d44fdc 
Some applications or gems don't require sprockets/rails, instead they
load sprockets/railtie.

This change catches this issue when running tests.
@etiennebarrie etiennebarrie mentioned this pull request Jun 10, 2024
Merged
@rafaelfranca rafaelfranca merged commit 5b0c81d into rails:master Jul 31, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etiennebarrie @rafaelfranca